8000 build: Specify boost include directory for FpeMonitoring by njacazio · Pull Request #4354 · acts-project/acts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build: Specify boost include directory for FpeMonitoring #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Specify boost include directory for FpeMonitoring #4354

wants to merge 1 commit into from
+1 −0

Conversation

Copy link
@njacazio njacazio commented Jun 18, 2025 •
edited by coderabbitai bot
Loading

When building ACTS boost/stacktrace.hpp can not be found.

CMake Error at Plugins/FpeMonitoring/CMakeLists.txt:27 (find_path):
Could not find boost_stacktrace_include using the following files:
boost/stacktrace.hpp

This specifies the boost include directory

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

Summary by CodeRabbit

  • Chores
    • Improved the build configuration to better locate required Boost library files during setup. No impact on user-facing features.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jun 18, 2025 •
edited
Loading

Walkthrough

Explicitly added, the Boost include directories are, to the search path for the boost/stacktrace.hpp header in the CMake configuration. Changed, only the find_path command is, with no other logic or control flow affected.

Changes

File(s) Change Summary
Plugins/FpeMonitoring/CMakeLists.txt Added PATHS ${Boost_INCLUDE_DIRS} to find_path for Boost header.

Poem

Seek the header, find the path,
In CMake’s wisdom, none shall lack.
Boost’s power, now revealed,
Stacktrace’s fate, firmly sealed.
Jedi builders, onward go—
With clearer paths, the code shall flow!
✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@njacazio njacazio marked this pull request as ready for review June 18, 2025 11:41
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Jun 18, 2025
coderabbitai[bot]
coderabbitai bot reviewed Jun 18, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Plugins/FpeMonitoring/CMakeLists.txt (1)

31-31: Prefer HINTS over PATHS for Boost variables, you should.
Using HINTS ${Boost_INCLUDE_DIRS} leverages CMake’s prefix search and the provided include dirs together:

find_path(
  boost_stacktrace_include
  NAMES "boost/stacktrace.hpp"
  REQUIRED
  HINTS ${Boost_INCLUDE_DIRS}
)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ac6152 and f8f5cb5.

📒 Files selected for processing (1)
  • Plugins/FpeMonitoring/CMakeLists.txt (1 hunks)
🔇 Additional comments (1)
Plugins/FpeMonitoring/CMakeLists.txt (1)

31-31: Check for the Boost import, we must. Run this script, you should:

#!/bin/bash
FILE="Plugins/FpeMonitoring/CMakeLists.txt"
if [ -f "$FILE" ]; then
  rg -n "find_package\\s*\\(Boost" "$FILE" || echo "No find_package(Boost…) found"
else
  echo "File $FILE not found"
fi

@github-actions github-actions bot added this to the next milestone Jun 18, 2025
@paulgessinger paulgessinger changed the title Specify boost include directory for FpeMonitoring build: Specify boost include directory for FpeMonitoring Jun 18, 2025
@paulgessinger paulgessinger self-requested a review June 18, 2025 12:48
@github-actions GitHub Actions
Copy link
Contributor

📊: Physics performance monitoring for f8f5cb5

Full contents

physmon summary

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@paulgessinger paulgessinger Awaiting requested review from paulgessinger

Assignees
No one assigned
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
1 participant
@njacazio
0