Retry artifact uploads on HTTP 500 #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacaovsnc
approved these changes
Jun 4, 2021
|
8000
Backed out the change to the package version; we'll do that along with the release notes when we release the update |
yaananth
approved these changes
Jun 4, 2021
lvpx
added a commit
that referenced
this pull request
Jul 13, 2022
lvpx
added a commit
that referenced
this pull request
Aug 3, 2022
rmg
added a commit
to rmg/toolkit
that referenced
this pull request
Jun 20, 2023
actions/cache occasionally gets 500 errors like actions/upload-artifact does, but it just fails instead of retrying like upload-artifact does. This adds retrying on 500 errors to @actions/cache the same way it was added to @actions/artifact in actions#833.
rmg
added a commit
to rmg/toolkit
that referenced
this pull request
Aug 17, 2023
actions/cache occasionally gets 500 errors like actions/upload-artifact does, but it just fails instead of retrying like upload-artifact does. This adds retrying on 500 errors to @actions/cache the same way it was added to @actions/artifact in actions#833.
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
* Retry on 500 * bump package version * fix tests * Remove spurious change * fix another test * Roll back package version
rmg
added a commit
to rmg/toolkit
that referenced
this pull request
Sep 5, 2023
actions/cache occasionally gets 500 errors like actions/upload-artifact does, but it just fails instead of retrying like upload-artifact does. This adds retrying on 500 errors to @actions/cache the same way it was added to @actions/artifact in actions#833.
rmg
added a commit
to rmg/toolkit
that referenced
this pull request
May 16, 2024
actions/cache occasionally gets 500 errors like actions/upload-artifact does, but it just fails instead of retrying like upload-artifact does. This adds retrying on 500 errors to @actions/cache the same way it was added to @actions/artifact in actions#833.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have gotten bug reports of https://github.com/actions/upload-artifact/ failing when the service returns HTTP 500, which we do not retry on currently. An HTTP 500 may be an intermittent or instance-specific issue, so retrying here should improve reliability.
We already perform exponential backoff with jitter on retries. We discussed whether we should lengthen the retry interval. Right now the intervals are:
I think we can consider that out-of-scope for this change. If we find that retries are not effective or putting too much pressure on the service, we can look at data and figure out what a better backoff multiplier would be.