Updating blob storage client to 12.13.0 in actions/cache #1363
Conversation
Upgrade ts version to support latest azure sdk
| @@ -4,7 +4,8 @@ | |||
| "baseUrl": "./", | |||
| "outDir": "./lib", | |||
| "rootDir": "./src", | |||
| "lib": ["es6", "dom"] | |||
| "lib": ["es6", "dom"], | |||
| "useUnknownInCatchVariables": false | |||
There was a problem hiding this comment.
Added this because the ts compiler raised issues with the catch block err variable having no type defined. Use of Error, any and unknown was also not allowed.
packages/cache/package.json
Outdated
| "semver": "^6.1.0", | ||
| "uuid": "^3.3.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/semver": "^6.0.0", | ||
| "@types/uuid": "^3.4.5", | ||
| "typescript": "^3.8.3" | ||
| "typescript": "~4.8.0" |
There was a problem hiding this comment.
The root level package.json uses a different typescript version. Wondering how Lerna resolves the version when running build/test commands.
There was a problem hiding this comment.
On first attempt I had received an error saying version mismatch, but running npm install and updating the package-lock.json file resolved the issue. I think it uses lockfile to resolve the dev dependencies as well.
Also easy to debug going forward as we'll have whole MB segments and not fractional for any error in mid of a segment.
|
Can someone from @actions/actions-runtime team please review if the typescript update has been done correctly? We have to upgrade it to 4.x to support the newer versions of the @azure/storage-sdk. 🙇🏽♂️ |
| @@ -101,7 +101,7 @@ export function getDownloadOptions(copy?: DownloadOptions): DownloadOptions { | |||
| useAzureSdk: true, | |||
| downloadConcurrency: 8, | |||
| timeoutInMs: 30000, | |||
| segmentTimeoutInMs: 3600000, | |||
| segmentTimeoutInMs: 600000, | |||
There was a problem hiding this comment.
These were not updated to match:
toolkit/packages/cache/src/options.ts
Lines 50 to 55 in 4573039
and README was updated in #1367 but RELEASES wasn't
toolkit/packages/cache/RELEASES.md
Lines 160 to 162 in 4573039
This PR updates the blob storage client to v12.13.0 which is the latest to accommodate the latest SDK changes in cache library.
Also updated the typescript version because the builds were failing and azure sdk uses typescript 4.8.0