8000 Patch @actions/cache to use @action/core version 1.10.0 by lvpx · Pull Request #1206 · actions/toolkit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Patch @actions/cache to use @action/core version 1.10.0 #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2022
Merged

Patch @actions/cache to use @action/core version 1.10.0 #1206

merged 3 commits into from
Oct 13, 2022

Conversation

lvpx
Copy link
Contributor
@lvpx lvpx commented Oct 13, 2022

Update @action/cache package to use the version 1.10.0 of @actions/core.

@lvpx lvpx requested a review from a team as a code owner October 13, 2022 08:23
@bishal-pdMSFT
Copy link
Contributor

Doesn't it need a code change to remove usage of save-state and set-output?

@bishal-pdMSFT
Copy link
Contributor

Doesn't it need a code change to remove usage of save-state and set-output?

Looks like that is handled internally

toolkit/packages/core/src/core.ts

Line 355 in 1bc93f3

return issueFileCommand('STATE', prepareKeyValueMessage(name, value))

@lvpx
Copy link
Contributor Author
lvpx commented Oct 13, 2022

The code changes happened on the actions/cache side here.

Phantsure
Phantsure reviewed Oct 13, 2022
View reviewed changes
aparna-ravindra
aparna-ravindra reviewed Oct 13, 2022
View reviewed changes
Phantsure
Phantsure approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor
@Phantsure Phantsure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lvpx lvpx merged commit ffb7e3e into main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparna-ravindra aparna-ravindra aparna-ravindra left review comments

@Phantsure Phantsure Phantsure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvpx @bishal-pdMSFT @Phantsure @aparna-ravindra
0