cache: unlock zstd long mode and add support for zstd --adapt
#1772
Conversation
| if (versionOutput === '') { | ||
| if (version === null) { | ||
| return CompressionMethod.Gzip | ||
| } else { | ||
| } else if (semver.lt(version, '1.3.2')) { | ||
| return CompressionMethod.ZstdWithoutLong | ||
| } else if (semver.lt(version, '1.3.6')) { | ||
| return CompressionMethod.ZstdWithoutAdapt | ||
| } else { | ||
| return CompressionMethod.Zstd |
There was a problem hiding this comment.
This should also fix this bug, as it seems we have not actually been able to use long mode yet.
| @@ -207,6 +207,7 @@ async function getDecompressionProgram( | |||
| // Used for creating the archive | |||
| // -T#: Compress using # working thread. If # is 0, attempt to detect and use the number of physical CPU cores. | |||
| // zstdmt is equivalent to 'zstd -T0' | |||
| // --adapt: Dynamically adapt compression level to I/O conditions. | |||
There was a problem hiding this comment.
15cc910 to
2faac2a
Compare
|
Ready to merge! |
|
Gentle ping @robherley |
|
@robherley ping |
|
@nebuk89 How do we move this forward? |
|
Gentle reminder |
|
@joshmgross ping |
|
ping @joshmgross |
|
👋 Hey @smorimoto, Thank you for this change! I don't think we have capacity to fully validate and test this change at the moment, but I'll keep in mind in the future when we're ready to invest more in this cache package. |
|
Gentle ping |
Signed-off-by: Sora Morimoto <sora@morimoto.io>
zstd --adaptzstd --adapt
|
Gentle ping @robherley |
|
Can you review this? @salmanmkc |
|
@smorimoto please stop pinging GitHub Staff on this issue:
My previous response still applies - we don't have capacity at the moment to validate, test, and rollout this change. |
|
I really don’t want to mention anyone else either, but it seems the GitHub Actions team has been struggling with triage for several years now. |
|
@smorimoto I understand your disappointment, but pinging random GitHub Staff on pull requests is not the solution. Your feedback is appreciated though. |
If I remember correctly, we had that support before, but somehow it seems to have been removed at some point. This PR not only brings it back to keep the cache toolkit fast, but also "actually" enables long mode as described below.
At least the official GitHub Actions images have fairly new zstd installed on all platforms, so once merged we get all the benefits.