8000 Fix bug introduced in 4.2.0 by GhadimiR · Pull Request #391 · actions/download-artifact · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix bug introduced in 4.2.0 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from 8000
Mar 19, 2025
Merged

Fix bug introduced in 4.2.0 #391

merged 4 commits into from
Mar 19, 2025

Conversation

GhadimiR
Copy link
Contributor
@GhadimiR GhadimiR commented Mar 18, 2025

The output statements used to print download summary info & set download path output were erroneously moved to inside a loop, this change moves them back outside the loop, to ensure they are executed the correct amount of times in every case.

Closes this issue

@GhadimiR GhadimiR requested a review from a team as a code owner March 18, 2025 21:27
8000 Copy link
Member
@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include tests to avoid future regressions?

And can you link to the issue this is fixing?

@joshmgross joshmgross merged commit 95815c3 into actions:main Mar 19, 2025
7 checks passed
@joshmgross joshmgross mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Regression in 4.2.0 -- download-path is no longer populated if no artifacts are found with pattern match
2 participants
0