Use cache in check-dist.yml #192

jongwooo · 2022-12-06T16:15:53Z

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Use cache in check-dist.yml
See actions/cache#1004

AS-IS

- name: Set Node.js 12.x
  uses: actions/setup-node@v1
  with:
    node-version: 12.x

TO-BE

- name: Set Node.js 12.x
  uses: actions/setup-node@v3
  with:
    node-version: 12.x
    cache: npm

It’s literally a one line change to pass the cache: npm input parameter.

Signed-off-by: jongwooo <jongwooo.han@gmail.com>

konradpabjan · 2023-01-04T22:33:02Z

Thank you for initially opening this PR.

I'm closing this out though now because the workflow has been updated with a few more changes, including a newer node version + actions:

Lines 28 to 31 in 9bc31d5

    
           uses: actions/setup-node@v3 
        
           with: 
        
             node-version: 16.x 
        
             cache: 'npm'

Use cache in check-dist.yml

4a890f6

Signed-off-by: jongwooo <jongwooo.han@gmail.com>

jongwooo requested a review from a team as a code owner December 6, 2022 16:15

konradpabjan closed this Jan 4, 2023

jongwooo deleted the chore/use-cache-in-check-dist branch January 4, 2023 23:44