-
Notifications
You must be signed in to change notification settings - Fork 574
Fix concurrent artifact downloads #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Serious-senpai
wants to merge
3
commits into
actions:main
Choose a base branch
from
Serious-senpai:patch-1
base: main
< 8000 input-demux-context-wrapper data-context-type="baseChange">Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/download-artifact.ts:115
- [nitpick] Consider renaming 'chunk' to 'artifactChunk' for improved clarity, as 'chunk' is a generic term.
for (const chunk of chunkedArtifacts) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
PARALLEL_DOWNLOADSis set to 5, the promises are constructed at the same time. Therefore, chunking is meaningless at the moment.This PR fixes workflows that require downloading a great number of artifacts. For example: