8000 Uptake of the latest changes for helpers submodule by nikolai-frolov · Pull Request #41 · actions/go-versions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Uptake of the latest changes for helpers submodule #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

nikolai-frolov
Copy link
Contributor

Description

This PR uptakes the latest changes for helpers submodule. These changes update logic of versions-manifest.json gathering for Validate manifest workflow runs. It allows usage of already synced up file instead of new one downloading by url. (actions/versions-package-tools#39).

Related issue: https://github.com/actions/virtual-environments-internal/issues/2800

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@miketimofeev
Copy link

Do we need the Test-DownloadUrl function if there is no Url now?

@MaksimZhukov
Copy link
Contributor

Do we need the Test-DownloadUrl function if there is no Url now?

The Test-DownloadUrl function is used here to validate download_url of release asset, for example. Access token is used inside this function.

@MaksimZhukov MaksimZhukov merged commit 4e55ba9 into actions:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0