Add new setting save-on-success. #1571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Proposal to implement actions#1570
b38d23e to
40b3745
Compare
eirnym
approved these changes
Apr 30, 2025
|
What is the status of this? This could really improve our workflows! |
Rossbro2
reviewed
May 21, 2025
Rossbro2
reviewed
May 21, 2025
Co-authored-by: Kyle Ross <37418852+Rossbro2@users.noreply.github.com>
Co-authored-by: Kyle Ross <37418852+Rossbro2@users.noreply.github.com>
An owner needs to approve the workflows and merge on green :-) |
Rossbro2
approved these changes
May 21, 2025
|
@salmanmkc any chance you could approve, merge & release this? I've tested this on a fork and this is working great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to implement #1570, https://github.com/actions/cache/discussions/1598
Description
Allows to control whether new caches can be written in post action on success.
Motivation and Context
In some cases you want to read but not save a new cache. For instance when you run workflows on a tag action, then you probably want to read caches from the main/default branch, but you most likely do not want to create new caches. The current solution is to separate restore and save actions which is cumbersome.
In #1452 the always_save feature was removed.
I propose to add a new config save-on-success that defaults to true and can be set false to prevent cache writing. Now this new value can be set from available context - just like you could when separating the steps - granted the decision must be available upfront. That above described decision is in fact available immediately on job creation. So we can use the new setting to simplify the setup.
How Has This Been Tested?
Local experiments
Screenshots (if appropriate):
Types of changes
Checklist: