8000 Fix #4375: Swap EnvironmentDetector to use new loophp/phposinfo by petergr · Pull Request #4377 · acquia/blt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix #4375: Swap EnvironmentDetector to use new loophp/phposinfo #4377

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Fix #4375: Swap EnvironmentDetector to use new loophp/phposinfo #4377

merged 4 commits into from
Jun 29, 2021

Conversation

petergr
Copy link
Contributor
@petergr petergr commented May 26, 2021 •
edited by danepowell
Loading

Motivation
Fixes #4375

Proposed changes
Update the src/Robo/Common/EnvironmentDetector.php to use the new loophp/phposinfo instead of the abandoned drupol/phposinfo

Testing steps

  • Run at least composer update acquia/blt --with-all-dependences and confirm no errors

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@petergr petergr changed the title Fix #4375: Add required drupol/phposinfo dependency Fix #4375: Swap EnvironmentDetector to use new loophp/phposinfo Jun 1, 2021
@petergr petergr marked this pull request as draft June 2, 2021 11:47
@danepowell
Copy link
Contributor

Test failure seems like an upstream bug, seeing if re-running the test fixes it (need loophp/osinfo ^1.7): loophp/phposinfo@d4cda34

@danepowell
Copy link
Contributor

Well, sadly the loophp/phposinfo 1.6.5 namespaces are borked, and 1.7.0 requires PHP 7.4. This puts us in quite a tough spot. Upstream issue: loophp/phposinfo#1

@drupol
Copy link
drupol commented Jun 29, 2021

Fixed in https://github.com/loophp/phposinfo/releases/tag/1.7.1 ! Sorry about this!!!

@danepowell danepowell added the Bug Something isn't working label Jun 29, 2021
@danepowell danepowell marked this pull request as ready for review June 29, 2021 16:13
@danepowell danepowell merged commit 21fc824 into acquia:main Jun 29, 2021
@danepowell
Copy link
Contributor

Thanks for the PR, and for the quick fix!

@petergr petergr deleted the issue-4375 branch June 30, 2021 06:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP Fatal error: Uncaught Error: Class 'drupol\phposinfo\OsInfo' not found
3 participants
@petergr @danepowell @drupol
0