This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Project creation fails if Git config not set #4357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes https://github.com/acquia/cli/issues/427
Proposed changes
Call init-repo command to ensure Git validation runs and dummy credentials are set.
It looks like we missed this when first adding Git validation because we only tested in the context of the deploy and init-repo commands: #3511
Alternatives considered
Get rid of the initial Git commit altogether, it seems like an overstep given BLT's new role as a more focused Composer package. Previous discussion at #3511
Testing steps
Run
blt internal:add-to-project -non an uninitialized project with no Git username or email set and ensure it passes.Merge requirements