Migrate Github API authentication to new spec #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 81.65% 81.44% -0.22%
==========================================
Files 6 6
Lines 387 388 +1
==========================================
Hits 316 316
- Misses 71 72 +1
Continue to review full report at Codecov.
|
|
Yep, looks good. Can you add a changelog entry ? |
|
Sure, what would be the version bump? |
|
2.1 sounds good, yes |
Starting on September 8 2021, it will no longer be possible to authenticate API requests passing the token as a query parameter. Instead, it should be passed in the header. See https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ TT31500
ff3274e to
98aeeb8
Compare
|
Thanks, change done 👍 |
|
@sbidoul Github already blocked the URL parameter authentication, and it now produces a |
|
@joao-p-marques I just tagged 2.1.0. It should land on PyPI soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting on September 8 2021, it will no longer be possible to authenticate API requests passing the token as a query parameter.
Instead, it should be passed in the header.
See https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
@Tecnativa
TT31500
ping @yajo @sbidoul