8000 Update acisfp_check to allow for HRC dependence in the ACIS FP model by jzuhone · Pull Request #75 · acisops/acis_thermal_check · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update acisfp_check to allow for HRC dependence in the ACIS FP model #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 9, 2024
Merged

Update acisfp_check to allow for HRC dependence in the ACIS FP model #75

merged 8 commits into from
Dec 9, 2024

Conversation

jzuhone
Copy link
Member
@jzuhone jzuhone commented Dec 9, 2024

Description

As of chandra_models version 3.58, the ACIS FP model now depends on the HRC on/off state. These code changes allow the new model to be used with acisfp_check, with backwards-compatibility ensured for previous versions of the model without the HRC state dependence. Some changes to the testing infrastructure were required.

I also fixed a few formatting issues to satisfy ruff.

Interface impacts

None.

Testing

Testing infrastructure needed to be adjusted so that the new model could be tested alongside the old one.

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Functional tests

Tested the acisfp_check script on several loads in the last few weeks, webpages were created and thermal violations that appeared in the flight version were cleared in this version

Gregg140
Gregg140 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor
@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@jzuhone jzuhone merged commit f9f2438 into master Dec 9, 2024
1 check passed
This was referenced Dec 9, 2024
Closed
Merged
@javierggt javierggt mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregg140 Gregg140 Gregg140 approved these changes

@jazan12 jazan12 jazan12 approved these changes

Assignees

@Gregg140 Gregg140

@jazan12 jazan12

Labels
None yet
49F3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzuhone @Gregg140 @jazan12
0