8000 Loosened requirement for psr/http-message - ^1.0|^2.0 by Rastusik · Pull Request #107 · ackintosh/ganesha · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Loosened requirement for psr/http-message - ^1.0|^2.0 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2023
Merged

Loosened requirement for psr/http-message - ^1.0|^2.0 #107

merged 3 commits into from
Aug 21, 2023

Conversation

Rastusik
Copy link
Contributor

This PR was created according to #106

mad-briller
mad-briller reviewed Aug 18, 2023
View reviewed changes
composer.json Outdated
@@ -18,7 +18,7 @@
],
"require": {
"php": ">=8.0",
"psr/http-message": "~1.0"
"psr/http-message": "^1.1|^2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will increase the minimum as well as the maximum, this should probably be ^1.0 to ensure full backwards compatibility

Copy link
Contributor Author
@Rastusik Rastusik Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. feel free to squash, I did this using Github so I was not able to rebase.

@Rastusik
Copy link
Contributor Author

@mad-briller not sure what is wrong with the CI but I suppose it is not related to this PR, is it?

@coveralls
Copy link
coveralls commented Aug 19, 2023 •
edited
Loading

Coverage Status

coverage: 93.148% (+1.0%) from 92.12% when pulling a06d4c5 on Rastusik:psr_http_message_1_or_2 into a4c08dc on ackintosh:master.

@ackintosh
Copy link
Owner

Yes, that's right. Some tests are flaky so I did rerun the CI and they're passed. 👌

@ackintosh
Copy link
Owner

I noticed that psr/http-message v2 is not used in the CI, will dig into that later.

https://github.com/ackintosh/ganesha/actions/runs/5901311195/job/16038538654?pr=107#step:5:53

Locking psr/http-message (1.1)

@ackintosh
Copy link
Owner

I have updated guzzle (in require-dev) and confirmed that:

  • psr/http-message 2.0 is used in Tests (8.2)
  • psr/http-message 1.0 is used in Tests (8.2, --prefer-lowest --prefer-stable)
  • All tests have passed 👍

@Rastusik
Copy link
Contributor Author
Rastusik commented Aug 21, 2023 •
edited
Loading

Thanks for the effort :)

@ackintosh ackintosh changed the title Loosened requirement for psr/http-message - ^1.1|^2.0 Loosened requirement for psr/http-message - ^1.0|^2.0 Aug 21, 2023
@ackintosh ackintosh merged commi 8000 t bc52a76 into ackintosh:master Aug 21, 2023
@ackintosh
Copy link
Owner

This PR has been released as v3.1.2. 🎉 https://github.com/ackintosh/ganesha/releases/tag/3.1.2

@Rastusik Thanks for your contribution! @mad-briller Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mad-briller mad-briller mad-briller left review comments

@ackintosh ackintosh ackintosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rastusik @coveralls @ackintosh @mad-briller
0