CI fixes #325
Merged
CI fixes #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace deprecated runners with newer ones. windows-2019 will be deprecated on 2025-06-30. Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
aut0
requested changes
May 13, 2025
examples/cci/ex02_Fully_Supported_Data_Type_Param/ex02_simple_ip.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
A preprocessor directive, introdued in SystemC 2.3.4, is used in QuickThreads asm files, but the preprocessor is not called by the build system. This was fixed with SystemC 3.0.0. Since this directive only make sense on Linux systems, the SystemC build will fail on Windows/macOS for 2.3.4. See: https://github.com/accellera-official/systemc/blob/5fc1469339775b54b1fcc2020ac744a58be5b50e/src/sysc/packages/qt/md/iX86_64.s#L76 Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
The tests are segfaulting in the CI when built with MinGW GCC. They pass when "ctest" is called directly, or when the CMake "check" target is called in an SSH session on the CI runner... Disable testing for this platform for now. Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
Signed-off-by: Antonios Salios <antonios.salios@rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR addresses some issues with the CI of this repository.
I've done the following:
The workflows now run on Ubuntu 22.04/24.04, Windows 2022, and macOS 13 (x86).
The GitHub Windows runner ships with LLVM, which uses Microsoft's C runtime. This PR installs and uses a version of Clang that uses the MinGW runtime instead.
Unfortunately, there is still a strange issue with the tests for MinGW GCC on Windows. When run in the CI (using the CMake "check" target), the tests segfault. If the tests are then re-run by calling "ctest" directly, the tests pass without any problems. The problem also does not occur when I run the "check" target manually over an SSH connection to the CI runner (using mxschmitt/action-tmate).
I've disabled testing for this platform for now and replaced it with a warning. This bug should be tracked in a separate issue.
BR
Antonios