ipoe: add support of ipoe without ipoe interface #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to use Accel-PPP server with IPoE but without the 'ipoe' kernel module interface. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Add ipoe-interface option documentation Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
When no IPOE interface is configured, "accel-cmd show sessions" does not display any "ifname". Display the server interface name instead in such a case. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
IPOE usually creates ipoeX interfaces and sets them into the ap_session vrf_name VRF. When the configuration requires no creation of such interface, the last step fails. Skip the setting of VRF when the interface is not set, which is the case when ipoe-interface=0 is configured. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Move interface configuration out of ap_session_accounting_started in order to prepare the next commit. Only a cosmetic change. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
IPOE usually creates ipoeX interfaces and configure it. When the configuration requires no creation of such interface, the last step fails. Skip the configuration of unset interfaces which normally happens when ipoe-interface=0 is configured. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
42c27f5 to
412f8a5
Compare
|
It is pretty strange feature that destroy so many functionality like shaper and etc. Could you plese describy why you exactly need IPoE without any interface? |
Sorry for my late reply. The main reason for that is the Linux kernel does not handle efficiently a lot of interfaces. Over 1000 interfaces, some latency is experienced. There are some linked list that handles the net devices in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to use Accel-PPP server with IPoE but without the 'ipoe'
kernel module interface.