8000 Port Pull request #123 from xebd repo (IPv6 DNS from Radius) by hardillb · Pull Request #69 · accel-ppp/accel-ppp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Port Pull request #123 from xebd repo (IPv6 DNS from Radius) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll 8000 occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Port Pull request #123 from xebd repo (IPv6 DNS from Radius) #69

wants to merge 1 commit into from

Conversation

hardillb
Copy link
Contributor
@hardillb hardillb commented Dec 10, 2022 •
edited
Loading

Port over xebd/accel-ppp#123 to the new repo in the hope of getting it merged

This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/

@hardillb
Copy link
Contributor Author

Test run failures appear to be time outs, so probably worth running just those again...

@svlobanov
Copy link
Contributor

Test run failures appear to be time outs, so probably worth running just those again...

don't worry for deb10 and ub18.04. it's a known issue https://phabricator.accel-ppp.org/T70 . most probably it will never be fixed. we

@hardillb hardillb mentioned this pull request Nov 10, 2024
Open
@hardillb hardillb changed the title Port Pull request #123 from xebd repo Port Pull request #123 from xebd repo (IPv6 DNS from Radius) Nov 10, 2024
@hardillb
Copy link
Contributor Author

Given the prompts on the PRs in the xebd repo to open them here, any chance of some movement on this one?

@AlexIT-FT
Copy link

What about this PR ? After more than 2 yeara?
Is it working ? It would be very usefull.

@sever-sever sever-sever requested a review from Copilot March 11, 2025 06:54
Copilot
Copilot AI reviewed Mar 11, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@hardillb
Copy link
Contributor Author

@AlexIT-FT it worked when I wrote it and as it still appears to apply cleanly I think chances are pretty good.

8000 I'm still running it, but based on the code base it was developed on as I've not needed to update for my usecase.

@AlexIT-FT
Copy link

@hardillb
I can confirm , it's working ... two weeks without problems, in my patched of Vyos 1.5
Thank you.

@sever-sever sever-sever mentioned this pull request Mar 27, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@themiron themiron Awaiting requested review from themiron

@nuclearcat nuclearcat Awaiting requested review from nuclearcat

@DmitriyEshenko DmitriyEshenko Awaiting requested review from DmitriyEshenko

@xebd xebd Awaiting requested review from xebd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hardillb @svlobanov @AlexIT-FT
0