Reverse the order of key-labels for "above" commands [#342] #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's say I have a window showing many (200) lines. Point is somewhere in the middle or bottom of the screen. I want to jump up say 5 lines. Avy was optimized to jump most easily way up to the top of the window rather than 5 lines up. To go upward, I almost always ended up typing two prompt chars. With the "above" cases for this commit, the order is now reversed, going up 5 lines will always just require typing a single char to jump. I feel that this should be the default behavior for the "above" commands. Isn't it most common to do shorter jumps
(defun my-avy-goto-line-above (&optional offset bottom-up)
"Goto visible line above the cursor.
OFFSET changes the distance between the closest key to the cursor and
the cursor
When ***BOTTOM-UP*** is non-nil, display avy candidates from top to bottom" |
|
@MicahElliott you can pass the bottom up arguement , no need to rewrite avy tree |
|
Thanks @sivaplaysmC, that's nice to see there's some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say I have a window showing many (200) lines. Point is somewhere
in the middle or bottom of the screen. I want to jump up say 5 lines.
Avy was optimized to jump most easily way up to the top of the window
rather than 5 lines up. To go upward, I almost always ended up typing
two prompt chars.
With the "above" cases for this commit, the order is now reversed,
going up 5 lines will always just require typing a single char to
jump. I feel that this should be the default behavior for the "above"
commands. Isn't it most common to do shorter jumps