10000 cgroupdriver is hardcoded to cgroupfs · Issue #1311 · abiosoft/colima · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cgroupdriver is hardcoded to cgroupfs #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
win-t opened this issue May 3, 2025 · 1 comment · Fixed by #1312
Closed

cgroupdriver is hardcoded to cgroupfs #1311

win-t opened this issue May 3, 2025 · 1 comment · Fixed by #1312

Comments

@win-t
Copy link
Contributor
win-t commented May 3, 2025

Hi, I want to report minor issue.
I just found out that cgroupdriver is hardcoded to cgroupfs

colima/environment/container/docker/daemon.go

Lines 42 to 47 in 9d0de69

// enable cgroupfs for k3s (if not set by user)
if _, ok := conf["exec-opts"]; !ok {
conf["exec-opts"] = []string{"native.cgroupdriver=cgroupfs"}
} else if opts, ok := conf["exec-opts"].([]string); ok {
conf["exec-opts"] = append(opts, "native.cgroupdriver=cgroupfs")
}

The effect is that docker will create cgroup directly under the root cgroup

Image

This is a violation of the systemd contract https://systemd.io/CGROUP_DELEGATION/

Image

we need to set native.cgroupdriver=systemd if the system is using systemd, but it is not configurable now because it is hardcoded
win-t pushed a commit to win-t/colima that referenced this issue May 3, 2025
fix: abiosoft#1311
23bd8c1
@win-t win-t mentioned this issue May 3, 2025
Merged
win-t pushed a commit to win-t/colima that referenced this issue May 3, 2025
fix: abiosoft#1311
7e1cd54
win-t pushed a commit to win-t/colima that referenced this issue May 3, 2025
fix: abiosoft#1311
d56856a
win-t pushed a commit to win-t/colima that referenced this issue May 3, 2025
fix: abiosoft#1311
fcbe61e
@win-t
Copy link
Contributor Author
win-t commented May 3, 2025 •
edited
Loading

I created the fix here #1312, please help review

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docker: fix cgroupdriver win-t/colima
1 participant
@win-t
0