Don't enforce inside returns with non-nil errors #52

abhinav · 2025-05-11T22:01:11Z

If a function has a struct return type alongside an error,
it's pretty standard to do this:

if err != nil {
    return MyStruct{}, fmt.Errorf("do thing: %w", err)
}

There's no reason to enforce required fields on the struct
because the contract is that the struct value is to be ignored
if the error is non-nil.

This change adds support to detect these cases and ignore them.
It is a bit messier than "ignore if part of return with non-nil error"
because we still want to enforce required fields if the non-nil error
itself is the thing with required fields, e.g.

return nil, &MyError{...} // and MyError has required fields

Resolves #37

If a function has a struct return type alongside an error, it's pretty standard to do this: if err != nil { return MyStruct{}, fmt.Errorf("do thing: %w", err) } There's no reason to enforce required fields on the struct because the contract is that the struct value is to be ignored if the error is non-nil. This change adds support to detect these cases and ignore them. It is a bit messier than "ignore if part of return with non-nil error" because we still want to enforce required fields if the non-nil error itself is the thing with required fields, e.g. return nil, &MyError{...} // and MyError has required fields Resolves #37

abhinav · 2025-05-11T22:01:13Z

This change is part of the following stack:

Don't enforce inside returns with non-nil errors #52 ◀

_{Change managed by git-spice.}

abhinav merged commit 6840cc4 into main May 11, 2025
4 checks passed

abhinav deleted the err-return branch May 11, 2025 22:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Don't enforce inside returns with non-nil errors #52

Don't enforce inside returns with non-nil errors #52

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Don't enforce inside returns with non-nil errors #52

Don't enforce inside returns with non-nil errors #52

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!