[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): add basic drag & drop functionality to homescreen #301

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

rpschube
Copy link
Contributor
@rpschube rpschube commented Aug 3, 2024

Attempting to add drag and drop functionality to home screen, allowing users to organize their apps however they'd like. I have it working right now, just need to consider how to best handle saving the order so that it persists. LocalStorage is fine for now I guess but eventually it'd be nice to save in the DB via the ProxyRouteConfig object (is there a field in that object I can rely on as a unique key?)

Used FormKit Drag & Drop as it's super freaking lightweight

Partially addresses #35

Demo

Copy link
cla-bot bot commented Aug 3, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

Copy link
cla-bot bot commented Aug 3, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

@azukaar
Copy link
Owner
azukaar commented Aug 4, 2024

While I really really appreciate your contributions, I would prefer for us to have a chat about features before trying to implement them, to prevent clashes between the plan and the PR (like it is the case now).
Basically I have a different design in mind for the dashboard editing, in a nutshell: having a JSON file in the config/dashboard folder which contains definition for both applications and widgets on the dashboard (with the possibility to create multiple ones, and customize many things like icon positions, groups, backgrounds, and so on).
Implementing drag and drop like this before implementing the backbone of the dashboard implementation is not possible.
If you'd like to work on the dashboard customization, I'd be more than happy to write a design document for you to start implementing thought, just let me know :)

@rpschube
Copy link
Contributor Author
rpschube commented Aug 4, 2024

@azukaar Totally understandable! Was just browsing through open issues and trying to pick off the list. I would love to work on this feature and am happy to follow your design for it if you have one in mind.

@azukaar
Copy link
Owner
azukaar commented Aug 6, 2024

Great @ryan-schubert ! I'll get in touch shortly, just need to put htings together :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants