Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAI APIを利用する際、gpt-4o-mini以外のモデル (GPT-4.1など) も利用できるように、設定画面からモデル名を指定できるようにする。 主な変更点: - `Config` に `OpenAiModelName` 設定項目を追加 (デフォルト値: "gpt-4o-mini") - 設定画面 (`ConfigWindow`) にモデル名を入力するTextFieldを追加 - `OpenAIClient` が設定されたモデル名を使用するように修正 - Config定義の構成をリファクタリングし、再宣言エラーを解消 - APIリクエスト時に使用するモデル名をデバッグログに出力する機能を追加
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to specify a custom OpenAI model name via the settings UI, updating both configuration and API request handling.
- Added a new Config setting (openAiModelName) with a default value "gpt-4o-mini".
- Updated the settings window (ConfigWindow.swift) to include a TextField for inputting the model name.
- Modified OpenAIClient and azooKeyMacInputController to use the configured model name and log it for debugging purposes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| azooKeyMac/Windows/ConfigWindow.swift | Added TextField and binding for OpenAI model name. |
| azooKeyMac/InputController/azooKeyMacInputController.swift | Updated API request to include the model name and enhanced related debug messages. |
| azooKeyMac/InputController/OpenAIClient.swift | Changed OpenAI request JSON construction to use the provided model name. |
| azooKeyMac/Configs/StringConfigItem.swift | Refactored config item definition for openAiApiKey. |
| azooKeyMac/Configs/CustomCodableConfigItem.swift | Added new config item for openAiModelName with default value. |
Comments suppressed due to low confidence (1)
azooKeyMac/Configs/CustomCodableConfigItem.swift:146
- [nitpick] Consider renaming the config property to align with the external branding 'OpenAI' (with AI in uppercase), for example, renaming 'openAiModelName' to 'openAIModelName'.
static let openAiModelName = OpenAiModelName()
f190c32 to
eef614d
Compare
eef614d to
fc82153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAI APIを利用する際、gpt-4o-mini以外のモデル (GPT-4.1など) も利用できるように、設定画面からモデル名を指定できるようにする。
主な変更点:
ConfigにOpenAiModelName設定項目を追加 (デフォルト値: "gpt-4o-mini")ConfigWindow) にモデル名を入力するTextFieldを追加OpenAIClientが設定されたモデル名を使用するように修正