feat(shell): introduce error output behavior feature #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ocramius support for https://github.com/laminas/automatic-releases/blob/f4a0b35bf35db0b8a66adcf9b557d4709e4b533f/src/Gpg/ImportGpgKeyFromStringViaTemporaryFile.php#L20-L21 without disabling escaping ;) |
Pull Request Test Coverage Report for Build 2286989541
💛 - Coveralls |
|
@azjezz not sure I follow 🤔 |
azjezz
commented
Feb 3, 2022
Comment on lines
7
to
56
| enum ErrorOutputBehavior { | ||
| /** | ||
| * Discard the standard error output. | ||
| */ | ||
| case DISCARD; | ||
|
|
||
| /** | ||
| * Append the standard error output content to the standard output content. | ||
| */ | ||
| case APPEND; | ||
|
|
||
| /** | ||
| * Prepend the standard error output content to the standard output content. | ||
| */ | ||
| case PREPEND; | ||
|
|
||
| /** | ||
| * Replace the standard output content with the standard error output content. | ||
| */ | ||
| case REPLACE; | ||
| } |
There was a problem hiding this comment.
feature behaviors to include:
- merge: merge both stdout and stderr, the order is not guaranteed, as both streams will be read concurrently, and which ever returns first will be first, this doesn't mean that one will come after the over, as stdout can write a chunk, then stderr, then stdout, so it will be mixed ( exactly what you see in your terminal when stderr is not redirected )
- redirect: redirect the stderr output of the process, to the stderr output of the current process.
There was a problem hiding this comment.
#335 introduces a streaming function which helps implement the merge, and redirect behaviors.
|
in laminas automatic release we had to disable escaping to redirect stderr to stdout, since gpg writes the key to stderr, now that is not needed since you can do: $stderr = Shell\execute('gpg', ['--import', $keyFileName], error_output_behavior: ErrorOutputBehavior::Replace);instead of: $stderr = Shell\execute('gpg', ['--import', Shell\escape_argument($keyFileName), '2>&1'], escape_arguments: false); |
b941ee3 to
366a6ac
Compare
Signed-off-by: azjezz <azjezz@protonmail.com>
366a6ac to
e2581de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credits for this idea goes to @fredemmott ( facebook/hhvm#8946 (reply in thread) )