8000 support select images as context by yzhangok · Pull Request #7533 · aws/aws-toolkit-vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support select images as context #7533

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support select images as context #7533

wants to merge 3 commits into from
+49 −15

Conversation

yzhangok
Copy link
@yzhangok yzhangok commented Jun 20, 2025 •
edited
Loading

Problem

WebView emit event to open system file dialog to use the VSC api to open file dialog, and the event need to be handled by extension

Solution

  1. Register the request between WebView and language server by adding case OPEN_FILE_DIALOG
  2. Add handling for event when language server request to open system file dialog, which is defined in languageClient.onRequest(ShowOpenDialogRequestType.method, async (params: ShowOpenDialogParams)
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yzhangok yzhangok requested a review from a team as a code owner June 20, 2025 06:53
@github-actions GitHub Actions
Copy link
  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@yzhangok yzhangok changed the title feat(lsp): support select images as context support select images as context Jun 24, 2025
@leigaol
Copy link
Contributor
leigaol commented Jun 25, 2025

don't merge unless CI passes

leigaol
leigaol reviewed Jun 25, 2025
View reviewed changes
packages/amazonq/src/lsp/client.ts
@@ -134,6 +134,7 @@ export async function startLanguageServer(
q: {
developerProfiles: true,
pinnedContextEnabled: true,
imageContextEnabled: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ready for launch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. is this going for launch? otherwise we can do this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leigaol leigaol leigaol left review comments

@ashishrp-aws ashishrp-aws ashishrp-aws left review comments

@ctlai95 ctlai95 ctlai95 approved these changes

@avi-alpert avi-alpert avi-alpert approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yzhangok @leigaol @ctlai95 @avi-alpert @ashishrp-aws
0