Intentionally redefine iovec in headers as CI #2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torben-hansen
approved these changes
Jun 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
=======================================
Coverage 78.85% 78.86%
=======================================
Files 640 640
Lines 109604 109604
Branches 15524 15511 -13
=======================================
+ Hits 86433 86437 +4
+ Misses 22472 22468 -4
Partials 699 699 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
approved these changes
Jun 26, 2025
Merged
skmcgrail
added a commit
that referenced
this pull request
Jun 27, 2025
## What's Changed * Rename SSL test files to match Scrutinice filter by @nhatnghiho in #2491 * Order tool output by options provided - x509 by @justsmth in #2454 * Fix Console Test Suite Execution Locally by @smittals2 in #2493 * Re-remove afunix.h by @justsmth in #2495 * Note a couple of typoed struct names that we'll leave alone. by @justsmth in #2499 * Document that EVP_PKEY_CTX_set_rsa_keygen_pubexp takes ownership by @justsmth in #2503 * Remove sys headers from bio.h by @samuel40791765 in #2508 * rwlock race tests is not a GoogleTest executable by @torben-hansen in #2509 * Add two new APIs to expose TLS 1.3 traffic secrets for kTLS by @skmcgrail in #2506 * Intentionally redefine iovec in headers as CI by @samuel40791765 in #2512 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-3316,CryptoAlg-3292,CryptoAlg-3310,CryptoAlg-3284, andCryptoAlg-3346.Description of changes:
An extension off of 9db959e, this commit adds "CI" for the change. Instead of adding a new integration CI dimension that's likely going to be ignored, the best (and noisier) way to enforce this was introducing a similar concept in one of the files that referenced
bio.h. The test files that includebio.hhave too many header file references to introduce this to, sobio_ssl.ccseemed like the more suitable choice.Testing:
Rolled back 9db959e and ran the build, the build does fail without the necessary change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.