8000 Fix logical bug and add test for tree-DRBG fork by torben-hansen · Pull Request #2504 · aws/aws-lc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix logical bug and add test for tree-DRBG fork #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: randomness_generation
Choose a base branch
from
Open

Fix logical bug and add test for tree-DRBG fork #2504

wants to merge 11 commits into from

Conversation

torben-hansen
Copy link
Contributor
@torben-hansen torben-hansen commented Jun 24, 2025 •
edited
Loading

Issues:

V1827078279

Description of changes:

Fixes a logical bug in the tree-DRBG that would prevent a reseed under UBE.
Adds test coverage for tree-DRBG under UBE's.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@torben-hansen torben-hansen requested a review from a team as a code owner June 24, 2025 19:01
github-actions[bot]
github-actions bot reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link
codecov-commenter commented Jun 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.95402% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.86%. Comparing base (3c4640a) to head (a2db12e).

Files with missing lines Patch % Lines
.../entropy/tree_drbg_jitter_entropy_isolated_test.cc 91.86% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##           randomness_generation    #2504      +/-   ##
=========================================================
+ Coverage                  78.83%   78.86%   +0.02%     
=========================================================
  Files                        637      637              
  Lines                     110352   110439      +87     
  Branches                   15628    15623       -5     
=========================================================
+ Hits                       87001    87093      +92     
+ Misses                     22598    22592       -6     
- Partials                     753      754       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torben-hansen @codecov-commenter
0