Make sure reseed interval constants are meaningful for the tree-DRBG and add test to assert reseed interval #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and add test to assert reseed interval
skmcgrail
approved these changes
Jun 5, 2025
dkostic
approved these changes
Jun 5, 2025
1bdf17e
into
aws:randomness_generation
1 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
TREE_JITTER_{GLOBAL,THREAD}_DRBG_MAX_GENERATEwhere previously equal to the max value - 1. This was not totally clear. The thread should allow 2^20 generate calls and the global 2^24 generate calls. Due to the-1, only 2^20-1 and 2^24-1 is allowed because thedrbg.reseed_counteris initialized to 1, and that's the counter used to perform the interval check.Add a unit test that verifies that the (thread) counter now allows 2^20. The same condition logic is used for the global, which in turn, is covered by the test and should allow 2^24.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.