Tidy up changes and merge rng tests #2457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
approved these changes
Jun 3, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## randomness_generation #2457 +/- ##
=========================================================
- Coverage 78.84% 78.83% -0.02%
=========================================================
Files 637 636 -1
Lines 110335 110336 +1
Branches 15629 15629
=========================================================
- Hits 86993 86982 -11
- Misses 22591 22602 +11
- Partials 751 752 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
approved these changes
Jun 3, 2025
586e2de
into
aws:randomness_generation
110 of 116 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Merge
rand_test.ccandnew_rand_test.cc, and put the resulting file intocrypto/fipsmodule/rand. Also include a few changes for tidiness.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.