Impl BIO_ADDR_xxx functions #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
========================================
Coverage 78.94% 78.95%
========================================
Files 635 636 +1
Lines 109272 109442 +170
Branches 15446 15475 +29
========================================
+ Hits 86270 86407 +137
- Misses 22323 22343 +20
- Partials 679 692 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
103c016 to
0c00c15
Compare
WillChilds-Klein
previously approved these changes
Jun 5, 2025
WillChilds-Klein
previously approved these changes
Jun 9, 2025
skmcgrail
reviewed
Jun 13, 2025
WillChilds-Klein
previously approved these changes
Jun 17, 2025
WillChilds-Klein
approved these changes
Jun 17, 2025
skmcgrail
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Implementation of several
BIO_ADDR-related functions (BIO_ADDR_new,BIO_ADDR_free,BIO_ADDR_clear,BIO_ADDR_rawmake,BIO_ADDR_family,BIO_ADDR_rawaddress, andBIO_ADDR_rawport) as described by OpenSSL here.Call-outs:
I skipped implementation of
BIO_ADDR_hostname_string,BIO_ADDR_service_string, andBIO_ADDR_path_stringas I had trouble finding anywhere they were actually used. I can add these if we think they will be needed.Testing:
Added tests to increase code coverage.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.