Correct typo in malloc debug environment variable #2391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
previously approved these changes
May 2, 2025
smittals2
previously approved these changes
May 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
==========================================
- Coverage 78.77% 78.76% -0.01%
==========================================
Files 620 620
Lines 107961 107961
Branches 15329 15329
==========================================
- Hits 85046 85038 -8
- Misses 22258 22266 +8
Partials 657 657 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smittals2
approved these changes
May 2, 2025
and
8000
rewhop
approved these changes
May 2, 2025
darylmartin100
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I don't think this is currently used for anything. While the malloc-test machinery is working atm, some errors won't be caught due to the typo. https://man7.org/linux/man-pages/man3/mallopt.3.html says it should be
MALLOC_CHECK_.The malloc test is sorta in a weird state. Upstream has migrated
mallochijack functions tomem.c. But not in this repo. However, the build support exists in the shape ofwhich does nothing...
Anyway, this could be useful for something, one day, so I left all the code there. For further features, some honorary mentions one could research are
MALLOC_PERTURB_andmcheck().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.