8000 Simplify urandom and move iOS source into its own file by torben-hansen · Pull Request #2379 · aws/aws-lc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplify urandom and move iOS source into its own file #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: randomness_generation
Choose a base branch
from
Open

Simplify urandom and move iOS source into its own file #2379

wants to merge 12 commits into from

Conversation

torben-hansen
Copy link
Contributor
@torben-hansen torben-hansen commented Apr 30, 2025 •
edited
Loading

Description of changes:

Refactor urandom.c to be more readable:

  • Introduces explicit states
  • Factor out code into self-contained functions
  • Removes if/defs, in particular, drops any FIPS macro's
  • Factors out iOS source CCRandomGenerateBytes() into its own file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link
codecov-commenter commented Apr 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.86957% with 59 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (51233d4) to head (c1900ff).

Files with missing lines Patch % Lines
crypto/rand_extra/urandom.c 37.07% 56 Missing ⚠️
crypto/fipsmodule/rand/rand_isolated_test.cc 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##           randomness_generation    #2379      +/-   ##
=========================================================
- Coverage                  78.74%   78.70%   -0.05%     
=========================================================
  Files                        637      637              
  Lines                     109341   109382      +41     
  Branches                   15494    15507      +13     
=========================================================
- Hits                       86099    86087      -12     
- Misses                     22519    22568      +49     
- Partials                     723      727       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@torben-hansen torben-hansen marked this pull request as ready for review April 30, 2025 17:25
@torben-hansen torben-hansen requested a review from a team as a code owner April 30, 2025 17:25
@torben-hansen
Copy link
Contributor Author

All these failures are known errors and some because fixes does not exist on target branch yet.

skmcgrail
skmcgrail previously approved these changes May 5, 2025
View reviewed changes
andrewhop
andrewhop reviewed May 6, 2025
View reviewed changes
skmcgrail
skmcgrail previously approved these changes May 6, 2025
View reviewed changes
@torben-hansen torben-hansen requested a review from skmcgrail May 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justsmth justsmth justsmth approved these changes

@andrewhop andrewhop Awaiting requested review from andrewhop

@skmcgrail skmcgrail Awaiting requested review from skmcgrail

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@torben-hansen @codecov-commenter @skmcgrail @andrewhop @justsmth
0