Add null check for EVP_get_digestbyobj #2360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
=======================================
Coverage 78.75% 78.76%
=======================================
Files 620 620
Lines 107956 107958 +2
Branches 15329 15331 +2
=======================================
+ Hits 85018 85030 +12
+ Misses 22282 22271 -11
- Partials 656 657 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
darylmartin100
approved these changes
Apr 24, 2025
justsmth
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some usages of Ruby were failing internally with a NULL pointer passed to this function. Ruby OpenSSL's usage tries to parse a string and obtain an
EVP_MDfrom it, but a NULL pointer is passed when an invalid string is used.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.