Add missing symbols for Unbound #2352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2352 +/- ##
==========================================
- Coverage 78.80% 78.78% -0.02%
==========================================
Files 621 621
Lines 108414 108427 +13
Branches 15400 15399 -1
==========================================
- Hits 85439 85429 -10
- Misses 22304 22327 +23
Partials 671 671 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
previously approved these changes
Apr 29, 2025
WillChilds-Klein
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #CryptoAlg-2907
Description of changes:
Add the following missing symbols to support building Unbound:
PKCS7_get0_signers: already exist, only had to externalize itEVP_PKEY_set_type_str: needed to enable building with Gost (adapted from OpenSSL)Call-outs:
This PR does not include any integration test since we need to implement
BIO_seekfor Unbound tests to pass. Integration test will come in a later PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.