8000 Tweaking clang-tidy config by justsmth · Pull Request #2329 · aws/aws-lc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tweaking clang-tidy config #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Tweaking clang-tidy config #2329

merged 1 commit into from
Apr 10, 2025

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • No more "Looks good to me!" comments.
  • Update to latest action version.
  • Add a few more lints.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@github-actions GitHub Actions
Copy link
Contributor

Looks good to me!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (e48f9f4) to head (296f45b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2329      +/-   ##
==========================================
- Coverage   78.77%   78.76%   -0.01%     
==========================================
  Files         620      620              
  Lines      107757   107757              
  Branches    15296    15297       +1     
==========================================
- Hits        84884    84877       -7     
- Misses      22218    22226       +8     
+ Partials      655      654       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth changed the title [DRAFT] Tweaking clang-tidy config Tweaking clang-tidy config Apr 10, 2025
@justsmth justsmth marked this pull request as ready for review April 10, 2025 15:39
@justsmth justsmth requested a review from a team as a code owner April 10, 2025 15:39
@justsmth justsmth requested a review from torben-hansen April 10, 2025 15:39
@justsmth
Copy link
Contributor Author

The "MSVC*" CI failures are being fixed on:

@justsmth justsmth merged commit 9043146 into aws:main Apr 10, 2025
109 of 114 checks passed
@justsmth justsmth deleted the clang-tidy-tweaks branch April 10, 2025 17:13
@justsmth justsmth mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torben-hansen torben-hansen torben-hansen approved these changes

@smittals2 smittals2 smittals2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justsmth @codecov-commenter @torben-hansen @smittals2
0