Update patch for Postgres #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a0f07d to
d9e0eba
Compare
samuel40791765
commented
Mar 1, 2025
Comment on lines
+17
to
+28
| +fi | ||
| +done | ||
| + | ||
| + # Function specific to AWS-LC. | ||
| + for ac_func in awslc_version_string | ||
| +do : | ||
| + ac_fn_c_check_func "$LINENO" "awslc_version_string" "ac_cv_func_awslc_version_string" | ||
| +if test "x$ac_cv_func_awslc_version_string" = xyes; then : | ||
| + cat >>confdefs.h <<_ACEOF | ||
| +#define HAVE_AWSLC_VERSION_STRING 1 | ||
| +_ACEOF | ||
| + |
There was a problem hiding this comment.
This was autogenerated via autoconf after adding the logic in configure.ac, which is what upstream postgres also does.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 612 612
Lines 106510 106510
Branches 15053 15051 -2
=======================================
+ Hits 84192 84193 +1
Misses 21664 21664
+ Partials 654 653 -1 ☔ View full report in Codecov by Sentry. |
justsmth
approved these changes
Mar 4, 2025
skmcgrail
approved these changes
Mar 10, 2025
samuel40791765
added a commit
to samuel40791765/aws-lc
that referenced
this pull request
Apr 23, 2025
This reverts commit db72311.
samuel40791765
added a commit
to samuel40791765/aws-lc
that referenced
this pull request
May 1, 2025
This reverts commit db72311.
samuel40791765
added a commit
that referenced
this pull request
May 2, 2025
This reverts commit db72311. The original patch was much more stable. Instead of changing the postgres configure script to check against AWS-LC functions, we comment out the relevant test instead. I've added comments in the patch to reference back to the commit if we ever decide to upstream support to postgres. The Postgres ARM CI dimension is failing, but the failure doesn't seem relevant to this patch. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
CryptoAlg-2917Description of changes:
The original patch I had for Postgres wasn't the best, as it just simply commented out the single test we didn't support. It's not a patch worthy of submitting upstream.
This new patch simply adds a function check specific to AWS-LC and leverages existing logic to skip the test. I've kept the error string replacements out of the script to minimize churn with our Postgres CI and left a comment regarding that.
Call-outs:
N/A
Testing:
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.