Pin the version of aws-lc-verification to a known working version #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37d7fa5 to
e2d9e5d
Compare
justsmth
reviewed
Oct 2, 2024
justsmth
previously approved these changes
Oct 2, 2024
justsmth
approved these changes
Oct 2, 2024
samuel40791765
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously this script always used the head of aws-lc-verification which will have diverged from this branch since the code on the FIPS 2022 branch is a snapshot of AWS-LC. I picked awslabs/aws-lc-verification@076973c as one of the last commits before we stopped touching this branch.
Testing:
This will hopefully get the CI to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.