8000 Update run_analytics.sh to skip ARM FIPS Static builds with GCC by andrewhop · Pull Request #678 · aws/aws-lc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update run_analytics.sh to skip ARM FIPS Static builds with GCC #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/ci/run_analytics.sh
< C1DA /div>
Original file line number Diff line number Diff line change
Expand Up @@ -117,5 +117,8 @@ no_assembly=OFF
fips=ON
run_build_and_collect_metrics

shared_library=OFF
run_build_and_collect_metrics
# The static FIPS build does not work on ARM with GCC, fix tracked in CryptoAlg-1399
if [[ ("$(uname -s)" == 'Linux'*) && (("$(uname -p)" == 'x86_64'*) || (("$(uname -p)" == 'aarch64') && ("$CC" == 'clang'*))) ]]; then
shared_library=OFF
run_build_and_collect_metrics
fi
2 changes: 1 addition & 1 deletion tests/ci/run_fips_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ echo "Testing AWS-LC shared library in FIPS Release mode."
fips_build_and_test -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=1

# Static FIPS build works only on x86_64 Linux platforms (both gcc and clang),
# and on aarch64 Linux platforms with clang.
# and on aarch64 Linux platforms with clang. Fix tracked in CryptoAlg-1399
if [[ ("$(uname -s)" == 'Linux'*) && (("$(uname -p)" == 'x86_64'*) || (("$(uname -p)" == 'aarch64') && ("$CC" == 'clang'*))) ]]; then
echo "Testing AWS-LC static library in FIPS Release mode."
fips_build_and_test -DCMAKE_BUILD_TYPE=Release
Expand Down
0