8000 Make a generic state file read/write mechanism by draftcode · Pull Request #289 · aviator-co/av · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make a generic state file read/write mechanism #289

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

Make a generic state file read/write mechanism #289

merged 1 commit into from
May 18, 2024

Conversation

draftcode
Copy link
Contributor
@draftcode draftcode commented May 15, 2024 •
edited
Loading

No description provided.

@aviator-app Aviator app
Copy link
Contributor
aviator-app bot commented May 15, 2024 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack

  1. 👉 Make a generic state file read/write mechanism #289 👈 (this pr)
  2. Add new sequencer object #288
  3. Add restack command #293
See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app Aviator app
Copy link
Contributor
aviator-app bot commented May 15, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @jainankit (current review load: 4)
  • @doratzeng (current review load: 2)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/commit_amend.go (1.00)
  • cmd/av/commit_create.go (1.00)
  • cmd/av/stack_reorder.go (1.00)
  • cmd/av/stack_sync.go (1.00)
  • internal/actions/sync_stack.go (1.00)
  • internal/git/state_file.go (1.00)
  • internal/reorder/reorder.go (1.00)
  • internal/reorder/reorder_test.go (1.00)
Files Reviewers
cmd/av/commit_create.go †,
cmd/av/stack_reorder.go †,
cmd/av/stack_sync.go †,
internal/actions/sync_stack.go †,
internal/git/state_file.go †,
internal/reorder/reorder_test.go †		 @jainankit (score: 0.42, current review load: 4)
cmd/av/stack_reorder.go †,
cmd/av/stack_sync.go †,
internal/git/state_file.go †,
internal/reorder/reorder.go †		 @doratzeng (score: 0.26, current review load: 2)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested review from doratzeng and jainankit May 15, 2024 21:00
@draftcode draftcode changed the base branch from new_sync to master May 17, 2024 22:08
@aviator-app aviator-app bot merged commit 030c318 into master May 18, 2024
3 checks passed
@aviator-app aviator-app bot deleted the state_read_write branch May 18, 2024 00:21
This was referenced May 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankit jainankit jainankit approved these changes

@doratzeng doratzeng Awaiting requested review from doratzeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@draftcode @jainankit
0