Tags: avaynshtok/sorbet
Tags
Fix Coverage.line_stub RBI (sorbet#2893)
Adding FactorialHR company (sorbet#2890) * Adding FactorialHR company * moving FactorialHR entry after Chan Zuckerberg
Add a test for new computed_by error (sorbet#2891) Also caught a bug where the code was using lit (which was nullptr) instead of val.
Report incorrect computed_by usage directly (sorbet#2889) I'm trying to split processProp into two halves: the half that parses a prop into it's data, and the half that consumes that data to write out new expressions. The logic for computed_by violates that: it writes out expressions and parses the data at the same time, so I rewrote it to not do that. I opted to introduce a new error, rather than relying on the error assertion from a `T.let` in infer. There's two reasons: 1. Don't have to prematurely change the tree before we've parsed a prop 2. The error is more specific: not only does it have to have type Symbol, it has to syntactically be a Symbol literal.
Improve caching of snapshot tests (sorbet#2885) * Improve caching of snapshot and hidden-method tests * Don't use exec_tools `exec_tools` adds one more bazel configuration, rather than skipping the host configuration.
Remove dead DataInterface code (sorbet#2886) It's not used at all on pay-server. Also shuffle some of the code around so that it's a little easier to read.
Add missing methods and parameters on Coverage. (sorbet#2817) Ruby 2.5 and 2.6 added some new methods to the Coverage module and updated some existing methods.
Change the rest of the helpers in ast::MK (sorbet#2884) This is a followup to sorbet#2882. Rather than stop at ast::Send, just do it for all of them.
Raise for unimplemented parts of rewriter phases (sorbet#2883) * Raise for unimplemented parts of rewriter phases Rather than lying and returning `nil` or accessing an instance variable or something, we should raise to indicate that the DSL pass is not fully accurate w.r.t. what would happen at runtime. * sto //test/cli:update_same-loc * tools/scripts/update_testdata_exp.sh * Raise for unimplemented parts of computed_by
Narrower types in ast::MK helpers (sorbet#2882) * Narrower types in ast::MK helpers This is nice because it means that calling one of these helpers is no worse and having created the object yourself. Specifically, the caller will be able to access fields of the object that was just created, like `flags` in the case of `ast::Send`. The changes from `x.swap(y)` to `x = move(y)` are all harmless, because in all cases were were constructing temporary values like unique_ptr<Expression> result; and swapping into them. `swap` only allows swapping when the objects are the exact same. For example, you can't swap an Expression into a Send. But you can `move` a `Send` into an `Expression`, and since we never cared about what was left in the non-result variable, it's fine to do this. * tools/scripts/format_cxx.sh
PreviousNext