test(ethhash): Use libevm #900
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
e05c528 to
5929fc9
Compare
alarso16
commented
May 22, 2025
| fwKeys = append(fwKeys, accHash[:]) | ||
| encodedVal, err := rlp.EncodeToBytes(acc) | ||
| require.NoError(t, err) | ||
| fwVals = append(fwVals, encodedVal) |
There was a problem hiding this comment.
How does this NOT change the hash???
There was a problem hiding this comment.
Ah yes, you found some of the ethhash magic. It doesn't matter what the hash is inside the data for an account. We compute the correct value and use that to hash the trie.
I was mistaken earlier when I stated that we never look at the data. We do some magic RLP encoding stuff to ensure compatibility with the hash at the top level, and we don't care what that hash is inside the data when computing the hash.
rkuris
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of importing
go-ethereum,libevmhas the same functionality, but maintained by us. Upon editing the file, there were additionally lint changes needed, as well as adding account changes to better emulate use cases.