Remove legacy warp handlers #999
Merged
+139
−668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
May 31, 2025
…eth into remove-legacy-warp-handlers
alarso16
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Before Etna we have added a support for acp118 handlers. After Etna this has become the default option for clients, so we should be able to remove legacy handlers.
How this works
This pull request removes support for warp signature requests in the
plugin/evmpackage, replacing the existing message and block signature request handling with a streamlined approach using protobuf-based signature requests. The changes simplify the codebase by eliminating redundant types, methods, and tests related to warp signature requests.Removal of Legacy Warp Signature Request Handling
Codebase Cleanup:
MessageSignatureRequest,BlockSignatureRequest, andSignatureResponsetypes fromplugin/evm/message/signature_request.go, along with their associated serialization, deserialization, and handling logic.plugin/evm/message/signature_request_test.go.Handler Updates:
HandleMessageSignatureRequestandHandleBlockSignatureRequestmethods from theRequestHandlerinterface inplugin/evm/message/handler.go.networkHandlerinplugin/evm/network_handler.goto remove handling logic for warp signature requests, including thesignatureRequestHandlerfield and its initialization. [1] [2]Transition to Protobuf-Based Signature Requests
NetworkSignatureGetterinwarp/aggregator/signature_getter.goto use protobuf-basedsdk.SignatureRequestmessages instead of the removed warp-specific request types.Test Updates
plugin/evm/vm_warp_test.goto use protobuf-based signature requests and responses, replacing legacy warp signature request tests with new test cases for message and block signature handling. [1] [2]These changes streamline warp signature handling, improve maintainability, and align the codebase with protobuf-based messaging standards.
How this was tested
Updated tests
Need to be documented?
No
Need to update RELEASES.md?
Yes