add warp tests for Coreth #1000
Conversation
So these have been reviewed already? It looks like |
There is no new files added here, some test files (under |
|
Notes to self and other reviewers. Compared against ava-labs/subnet-evm@6e67777:
|
There was a problem hiding this comment.
I've only reviewed the ways in which the Go differs from ava-labs/subnet-evm@6e67777 copied files. A couple of small things can be improved.
I think @maru-ava's review is important for this one.
There was a problem hiding this comment.
I've noticed a trend in recent subnet-evm and coreth PRs to move functionality from scripts to CI workflows. I think this is counterproductive - it encourages round-tripping through CI instead of just running things locally.
For future, I recommend following the example of avalanchego:
- All actions executed by CI are defined as tasks in the project Taskfile.yml
- The actionlint job enforces the requirement to not use scripts/ from CI
This enables both discoverability of available tasks (./scripts/run_task.sh without arguments outputs all tasks) and maximizes the potential for reproducing what runs in CI - it can be as simple as task [ci job].
Why this should be merged
Adds warp tests and simulator from subnet-evm
How this works
Clones tests/warp_test and cmd/simulator from subnet-evm and enables warp e2e testing in CI. This actually uses Subnet-EVM under the hood for Subnet<>C-chain warp tests.
How this was tested
e2e
Need to be documented?
No
Need to update RELEASES.md?
No