Fix bottom sheet flickering on Android #2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onghwan
reviewed
May 14, 2025
packages/core-mobile/app/new/common/hooks/useModalScreenOptions.tsx
Outdated
Show resolved
Hide resolved
onghwan
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dismissing a modal via gesture for some reason results in some flickering on Android. for now, looks like the best solution is just to use 0 duration transition on Android to prevent the flickering. the drawback is that it also affects the transition when pressing physical back button.
Screenshots/Videos
before
https://github.com/user-attachments/assets/bbeb7d85-e0e4-436c-8b1d-44b8f375510a
after
https://github.com/user-attachments/assets/ab56d2e6-07ad-42e0-bcac-b5f8cc393570
Checklist
Please check all that apply (if applicable)