Fix types for overloaded verify method #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Oct 15, 2021
| @@ -93,7 +95,22 @@ declare class IdTokenVerifier { | |||
| * @param {string} [requestedNonce] nonce value that should match the one in the id_token claims | |||
| * @param {verifyCallback} cb callback used to notify the results of the validation | |||
| */ | |||
| verify(token: string, requestedNonce?: string, cb: verifyCallback): any; | |||
| verify(token: string, requestedNonce: string, cb: verifyCallback): any; | |||
There was a problem hiding this comment.
@stevehobbsdev if requestedNonce is no longer optional, shouldn't the param doc line above stop using the [ ... ] ?
There was a problem hiding this comment.
Yes - good catch, I'll amend it. Thanks!
lbalmaceda
approved these changes
Oct 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR corrects the types for the overloaded
verifymethod. Currently the types are generated incorrectly thanks to an open issue in TypeScript.As a result, this PR also temporarily turns of automatic types generation.
References
#144
Testing
Checklist