Asynchronous JWKS cache #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests should now pass
adamjmcgrath
approved these changes
Jun 19, 2020
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR includes the ability to support asynchronous JWKS caches. These are classes in which the
has,get, andsetmethods (see theDummyCachecontract) return a Promise. This is backwards-compatible, so the methods can either return a Promise (or, more correctly, a then-able object), or synchronously return a value.This allows caching JWKS keys that are not synchronously available. For example, it could be possible for the application to request the keys and cache them (maybe even using a service worker).
Testing
Tests have been updated and are passing. Because the patch is backwards-compatible, tests that were not stubbing methods did not require any change. A couple of tests that were stubbing methods required minor tweaks. Additionally, a test has been added to use an asynchronous cache.
Checklist