Fixed bug with keys not first in keybag #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on a PR for auth0#100, realized this. Had to move the `if` statement outside of the for loop, or the `getJWKS` method would fail if the key isn't the first in the keybag.
This was referenced Mar 16, 2020
adamjmcgrath
approved these changes
Mar 16, 2020
4 tasks
|
Any indication on when this (kind of critical) bug fix will be released? |
|
@adamjmcgrath When will you be able to publish a release with this important fix? |
|
@ItalyPaleAle yep, apologies this slipped my mind, will prepare a release shortly |
Merged
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While working on a PR for #100, realized this. Had to move the
ifstatement outside of the for loop, or thegetJWKSmethod would fail if the key isn't the first in the keybag.Checklist