feat(show_models): track model_ids in cv_results #1628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiebergman
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Looks good, I'm not really sure of any concrete test that makes sense other than checking that the column exists so we can perhaps pass on that.
Edit: I also updated your title and description a little bit, the description noew says "Closes " just so github automatically tracks it, ("Fixes issue " doesn't work unfortunately). The title I changed to feat because technically it is some new feature, we can discuss this in person to settle on some agreement between us for it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #1628 +/- ##
===============================================
- Coverage 83.37% 83.24% -0.14%
===============================================
Files 156 156
Lines 11930 11931 +1
Branches 1897 1898 +1
===============================================
- Hits 9947 9932 -15
- Misses 1417 1430 +13
- Partials 566 569 +3 |
8332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1620
Corrects PR #1627
To improve flexibility, the id of each model is now also collected by cv_results.
The code I wrote is similar to what was already present in show_models.
Apart from small additions and changes to cv_results, I ended up deleting a nested function (has_key) in show_models in the hope of improving its readability.