js: Rename RawString to ImmutableString #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: RawString is an unhelpful name. A RawString is a string which is not collaborative, we don't create an op for each character in it but instead have a single op which sets the value of the whole string. It's useful when you expect to have a large string which will never be edited by a user (such as the output of a compilation step). Solution: Rename RawString to ImmutableString, which better reflects why you might use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: RawString is an unhelpful name. A RawString is a string which is not collaborative, we don't create an op for each character in it but instead have a single op which sets the value of the whole string. It's useful when you expect to have a large string which will never be edited by a user (such as the output of a compilation step).
Solution: Rename RawString to ImmutableString, which better reflects why you might use it.