8000 Persistent job queue prodcom by icanb · Pull Request #44 · autolab/Tango · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Persistent job queue prodcom #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000 Merged
merged 50 commits into from
Mar 18, 2015
Merged

Persistent job queue prodcom #44

merged 50 commits into from
Mar 18, 2015

Conversation

icanb
Copy link
Member
@icanb icanb commented Mar 18, 2015

The main purpose of this merge is to organize the project:

  1. Gets rid of the python libraries
  2. Creates a way to run the project with different port numbers
  3. Includes improvements to the config file.

After these changes, Tango can be daemonized with Supervisor and run though Nginx. So on surface, nothing has changed. With Redis off, it works the same way as the current Tango.

The merge also includes two other more substantial changes:

  1. Implementation of Redis based persistent memory. This feature is well tested at this point. But I'm not sure what happens when we call tangoReset on start twice (let's say if we started 2 tangos on the same machine)
  2. Producer/Consumer pattern. Having a persistent memory let's us use this pattern. Although this seems to be working for me, it's not well tested. We should also make sure that spinning 2 Tango instances does not create 2 consumers.

@icanb
Copy link
Member Author
icanb commented Mar 18, 2015

I'm making this the master since it doesn't change anything with Redis off (tested, and deployed to greatwhite with proper nginx setup). We can continue other feature debates from new PRs to the master.

icanb pushed a commit that referenced this pull request Mar 18, 2015
@icanb icanb merged commit c3f61db into master Mar 18, 2015
@icanb icanb mentioned this pull request Mar 18, 2015
@icanb icanb deleted the persistent_job_queue_prodcom branch March 18, 2015 12:00
@droh
Copy link
Member
droh commented Mar 18, 2015

Given the persistent job queue, it's very important that there be a way to
completely reset Tango to some initial empty state, with no running VMs and
an empty job queue.

It's also not clear to me what would (should) happen to running jobs in the
Redis queue when Tango is restarted.

-- David O'Hallaron
-- Prof of CS and ECE, Carnegie Mellon University
-- GHC 7517, x8-8199
-- http://www.cs.cmu.edu/~droh

On Wed, Mar 18, 2015 at 7:55 AM, Ilter notifications@github.com wrote:

Merged #44 #44.


Reply to this email directly or view it on GitHub
#44 (comment).

@icanb
Copy link
Member Author
icanb commented Mar 18, 2015

We have a resetTango method (https://github.com/autolab/Tango/blob/master/tangod.py#L178) and it gets called whenever the app starts, but I don't think it actually resets the jobQueue. I will change it so that it clears the jobQueue on Redis as well.

Also, on the prod-com model, I think having new producers should not reset Tango. There should only be one consumer, and tango should return to initial state when there is a new consumer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0